-
Notifications
You must be signed in to change notification settings - Fork 61
Amend NPM @nexthink reports to add fixed version #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend NPM @nexthink reports to add fixed version #1044
Conversation
Signed-off-by: David Sastre Medina <[email protected]>
a493014
to
7e220f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a go at making these changes yourself!
There's just one adjustment that needs to be made and I can merge the change.
{ | ||
"introduced": "0" | ||
"introduced": "0", | ||
"fixed": "6.72.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be:
[
{
"introduced": "0"
},
{
"fixed": "6.72.11"
}
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I should have done that. (I only quickly looked at the example in https://ossf.github.io/osv-schema/#format-overview and assumed incorrectly that I could write it like that).
I've checked them now against https://raw.githubusercontent.com/ossf/osv-schema/refs/heads/main/validation/schema.json
They should be OK now, I'll push the changes.
❯ for a in */*.json; do echo $a; check-jsonschema --schemafile ~/osv-schema.json $a; done
apollo-components/MAL-2022-455.json
ok -- validation done
apollo-tokens/MAL-2022-456.json
ok -- validation done
apollo-widgets/MAL-2022-457.json
ok -- validation done
arm-claims-library/MAL-2022-458.json
ok -- validation done
arm-jwt-decoder/MAL-2022-459.json
ok -- validation done
content-admin-list/MAL-2022-460.json
ok -- validation done
content-sharing/MAL-2022-461.json
ok -- validation done
data-formatter/MAL-2022-462.json
ok -- validation done
ea-widgets/MAL-2022-463.json
ok -- validation done
engage-branding/MAL-2022-464.json
ok -- validation done
engage-widgets/MAL-2022-465.json
ok -- validation done
flow-fe/MAL-2022-466.json
ok -- validation done
investigations-components/MAL-2022-467.json
ok -- validation done
investigations-editor/MAL-2022-468.json
ok -- validation done
investigations-widgets/MAL-2022-469.json
ok -- validation done
kendo-react/MAL-2022-470.json
ok -- validation done
nql-editor/MAL-2022-471.json
ok -- validation done
nxassignment/MAL-2022-472.json
ok -- validation done
nxnavigation/MAL-2022-473.json
ok -- validation done
remote-action-widgets/MAL-2022-474.json
ok -- validation done
waas/MAL-2022-475.json
ok -- validation done
Signed-off-by: David Sastre Medina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great.
Resolves #1039.